Skip to content

Remove dictionaries that cause typo false negatives #39277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2025

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Apr 25, 2025

We have a lot of typos that go unnoticed because they are included by cpp and django, which we don't even use that much. I've internalized the words that we do need.

Fix #39296

@Josh-Cena Josh-Cena requested a review from bsmth April 25, 2025 16:13
@Josh-Cena Josh-Cena requested review from a team as code owners April 25, 2025 16:13
@Josh-Cena Josh-Cena requested review from fred-wang, sideshowbarker, estelle and jpmedley and removed request for a team, fred-wang, sideshowbarker, estelle and jpmedley April 25, 2025 16:13
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 25, 2025
@github-actions github-actions bot added Content:Learn Learning area docs Content:HTTP HTTP docs Content:Accessibility Accessibility docs Content:SVG SVG docs Content:Media Media docs Content:wasm WebAssembly docs Content:MathML MathML docs Content:Glossary Glossary entries Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree Content:PWA Progressive Web Apps content system [PR only] Infrastructure and configuration for the project size/l [PR only] 501-1000 LoC changed labels Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Preview URLs (128 pages)
Flaws (173)

Note! 80 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Introduction
Title: Introduction to CSS layout
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect

URL: /en-US/docs/Learn_web_development/Core/Scripting/Conditionals
Title: Making decisions in your code — conditionals
Flaw count: 8

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/p which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/Heading_Elements which is a redirect
    • and 3 more flaws omitted

URL: /en-US/docs/Learn_web_development/Core/Scripting/Return_values
Title: Function return values
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/canvas which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/script which is a redirect

URL: /en-US/docs/Learn_web_development/Extensions/Forms/Sending_and_retrieving_form_data
Title: Sending form data
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect

URL: /en-US/docs/Learn_web_development/Extensions/Server-side/Django/Forms
Title: Django Tutorial Part 9: Working with forms
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Learn_web_development/Extensions/Server-side/Django/authentication_and_sessions
  • unknown:
    • page(Doc) not found /en-US/docs/Learn_web_development/Extensions/Server-side/Django/authentication_and_sessions

URL: /en-US/docs/Mozilla/Firefox/Releases/1.5/Using_Firefox_1.5_caching
Title: Using Firefox 1.5 caching
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/8
Title: Firefox 8 for developers
Flaw count: 7

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/textarea which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect
    • and 2 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/48
Title: Firefox 48 for developers
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/Archive/Web/Old_Proxy_API
    • Can't resolve /en-US/docs/Mozilla/Projects/Social_API/Service_worker_API_reference
    • Can't resolve /en-US/docs/Mozilla/Gecko/Chrome/CSS/-moz-bool-pref
  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/details which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/details which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/fieldset which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/57
Title: Firefox 57 (Quantum) for developers
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Headless_mode
    • Can't resolve /en-US/docs/Archive/Social_API
  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/details which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/113
Title: Firefox 113 for developers
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/RTCMediaSourceStats

URL: /en-US/docs/Mozilla/Firefox/Releases/119
Title: Firefox 119 for developers
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/132
Title: Firefox 132 for developers
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/link which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/script which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect

URL: /en-US/docs/Web/Accessibility/ARIA/Reference/Roles/button_role
Title: ARIA: button role
Flaw count: 9

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/Element/getClientRects
Title: Element: getClientRects() method
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/span which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/area which is a redirect

URL: /en-US/docs/Web/API/Element/moveBefore
Title: Element: moveBefore() method
Flaw count: 13

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/audio which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/article which is a redirect
    • and 8 more flaws omitted

URL: /en-US/docs/Web/API/EventTarget/addEventListener
Title: EventTarget: addEventListener() method
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect

URL: /en-US/docs/Web/API/FormDataEvent/formData
Title: FormDataEvent: formData property
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/Form which is a redirect

URL: /en-US/docs/Web/API/HTMLAudioElement
Title: HTMLAudioElement
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/audio which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/audio which is a redirect

URL: /en-US/docs/Web/API/HTMLDialogElement
Title: HTMLDialogElement
Flaw count: 6

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/HTMLElement/beforetoggle_event
Title: HTMLElement: beforetoggle event
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect

URL: /en-US/docs/Web/API/HTMLImageElement/alt
Title: HTMLImageElement: alt property
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect

URL: /en-US/docs/Web/API/ProgressEvent
Title: ProgressEvent
Flaw count: 5

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/audio which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/style which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/link which is a redirect

URL: /en-US/docs/Web/API/SubtleCrypto/deriveKey
Title: SubtleCrypto: deriveKey() method
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect

URL: /en-US/docs/Web/API/UI_Events
Title: UI Events
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/API/Element/select_event which is a redirect
    • Can't resolve /en-US/docs/Web/API/Window/abort_event
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Can't resolve /en-US/docs/Web/API/Window/abort_event

URL: /en-US/docs/Web/API/UI_Events/Keyboard_event_key_values
Title: Key values for keyboard events
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/API/Element/select_event which is a redirect
    • Can't resolve /en-US/docs/Web/API/Window/abort_event

URL: /en-US/docs/Web/API/Web_Workers_API/Using_web_workers
Title: Using Web Workers
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/script which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/script which is a redirect

URL: /en-US/docs/Web/API/WebRTC_API/Using_data_channels
Title: Using WebRTC data channels
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/API/RTCDtlsTransport/statechange_event

URL: /en-US/docs/Web/API/WebVTT_API
Title: WebVTT API
Flaw count: 6

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/track which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/track which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/track which is a redirect
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/::after
Title: ::after
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/li which is a redirect

URL: /en-US/docs/Web/CSS/:open
Title: :open
Flaw count: 10

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/details which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • and 5 more flaws omitted

URL: /en-US/docs/Web/CSS/@import
Title: @import
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration
    • Can't resolve /en-US/docs/Web/CSS/media-query-list
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • and 2 more flaws omitted

URL: /en-US/docs/Web/CSS/animation-delay
Title: animation-delay
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/animation-fill-mode
Title: animation-fill-mode
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/animation-iteration-count
Title: animation-iteration-count
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/container-type
Title: container-type
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/cross-fade
Title: cross-fade()
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/CSS_images/Replaced_element_properties
Title: Styling replaced elements
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/embed which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/fencedframe which is a redirect

URL: /en-US/docs/Web/CSS/font-variation-settings
Title: font-variation-settings
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/opacity
Title: opacity
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/pointer-events
Title: pointer-events
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/text-wrap
Title: text-wrap
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/p which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/heading_elements which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/HTML/Reference/Elements/details
Title: <details>: The Details disclosure element
Flaw count: 5

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/summary which is a redirect

URL: /en-US/docs/Web/HTML/Reference/Global_attributes/exportparts
Title: exportparts
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/template which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/slot which is a redirect

URL: /en-US/docs/Web/HTTP/Reference/Headers/Content-Security-Policy/report-uri
Title: CSP: report-uri
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/meta which is a redirect

URL: /en-US/docs/Web/HTTP/Reference/Headers/Cross-Origin-Embedder-Policy
Title: Cross-Origin-Embedder-Policy
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
  • unknown:
    • No generic content config found

URL: /en-US/docs/Web/MathML/Reference/Element/mtable
Title: <mtable>
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/table which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/tr which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/td which is a redirect

URL: /en-US/docs/Web/Media/Guides/Formats/Image_types
Title: Image file type and format guide
Flaw count: 10

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/link which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/object which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/embed which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • and 5 more flaws omitted

URL: /en-US/docs/Web/Media/Guides/Formats/Video_codecs
Title: Web video codec guide
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/source which is a redirect
External URLs (23)

URL: /en-US/docs/Learn_web_development/Core/Frameworks_libraries/Svelte_stores
Title: Working with Svelte stores


URL: /en-US/docs/Learn_web_development/Extensions/Server-side/Django/Home_page
Title: Django Tutorial Part 5: Creating our home page


URL: /en-US/docs/Learn_web_development/Getting_started/Soft_skills/Research_and_learning
Title: Research and learning


URL: /en-US/docs/Mozilla/Firefox/Releases/48
Title: Firefox 48 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/57
Title: Firefox 57 (Quantum) for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/113
Title: Firefox 113 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/119
Title: Firefox 119 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/129
Title: Firefox 129 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/132
Title: Firefox 132 for developers


URL: /en-US/docs/Web/Accessibility/ARIA/Reference/Roles/button_role
Title: ARIA: button role


URL: /en-US/docs/Web/API/HTMLAudioElement
Title: HTMLAudioElement


URL: /en-US/docs/Web/API/WebRTC_API/Using_data_channels
Title: Using WebRTC data channels


URL: /en-US/docs/Web/CSS/text-wrap
Title: text-wrap


URL: /en-US/docs/Web/Media/Guides/Formats/Image_types
Title: Image file type and format guide


URL: /en-US/docs/Web/Security/Transport_Layer_Security
Title: Transport Layer Security

(comment last updated: 2025-04-28 14:28:03)

@github-actions github-actions bot added the Content:Games Games docs label Apr 25, 2025
@OnkarRuikar
Copy link
Contributor

Can we remove latex, bash, softwareTerms, markdown dictionaries as well?

@Josh-Cena
Copy link
Member Author

Removing them generates only false positives and we do have legitimate usage of each, so I'm not motivated enough to remove them.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, one typo left, but otherwise looking good, tnx 👍🏻

Co-authored-by: Brian Smith <brian@smith.berlin>
@Josh-Cena Josh-Cena merged commit be1922d into mdn:main Apr 28, 2025
10 checks passed
@Josh-Cena Josh-Cena deleted the fix-typo branch April 28, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Games Games docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:Media Media docs Content:PWA Progressive Web Apps content Content:Security Security docs Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/l [PR only] 501-1000 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekly spelling check
3 participants